fix(acp): restore passing tests after acp v0.9 schema bump - #2813
Merged
Mason Daugherty (mdrxy) merged 1 commit intoApr 18, 2026
Merged
Conversation
Mason Daugherty (mdrxy)
requested a review
from Jacob Lee (jacoblee93)
as a code owner
April 18, 2026 00:55
github-actions
Bot
added
package:acp
![corridor-security[bot]](https://avatars.githubusercontent.com/in/1177339?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary: This PR updates ACP server compatibility with agent-client-protocol v0.9+ and introduces stricter type validation for session config options (rejecting non-string values), without adding new externally exposed attack surfaces.
Risk: Low risk. Changes are limited to internal configuration handling and tests, with added input validation that reduces potential misuse; no exploitable vulnerabilities were identified under the stated threat model.
Mason Daugherty (mdrxy)
deleted the
fix/acp-config-options-wrapper-tests
branch
April 18, 2026 00:56
Mason Daugherty (mdrxy)
added a commit
that referenced
this pull request
Apr 18, 2026
> [!CAUTION] > Merging this PR will automatically publish to **PyPI** and create a **GitHub release**. For the full release process, see [`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md). --- _Everything below this line will be the GitHub release body._ --- ## [0.0.6](deepagents-acp==0.0.5...deepagents-acp==0.0.6) (2026-04-18) ### Features * Add Opus 4.7 and Baseten to demo agent ([#2787](#2787)) ([bfb16a6](bfb16a6)) ### Bug Fixes * Restore passing tests after acp v0.9 schema bump ([#2813](#2813)) ([29a351a](29a351a)) --- _Everything above this line will be the GitHub release body._ --- > [!NOTE] > A **New Contributors** section is appended to the GitHub release notes automatically at publish time (see [Release Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline), step 2). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mason Daugherty <github@mdrxy.com>
james8814
pushed a commit
to james8814/deepagents
that referenced
this pull request
May 1, 2026
…-ai#2813) Restore test coverage for the ACP config-option wrapper compat added in langchain-ai#2700. When langchain-ai#2811 unbound `agent-client-protocol` to v0.9.0 (which dropped the `SessionConfigOption` wrapper), every `.root.<attr>` assertion in `test_model_switching.py` started raising `AttributeError` on `main`.
Marcelo5444
pushed a commit
to Marcelo5444/deepagents
that referenced
this pull request
Jul 30, 2026
…-ai#2813) Restore test coverage for the ACP config-option wrapper compat added in langchain-ai#2700. When langchain-ai#2811 unbound `agent-client-protocol` to v0.9.0 (which dropped the `SessionConfigOption` wrapper), every `.root.<attr>` assertion in `test_model_switching.py` started raising `AttributeError` on `main`.
Marcelo5444
pushed a commit
to Marcelo5444/deepagents
that referenced
this pull request
Jul 30, 2026
> [!CAUTION] > Merging this PR will automatically publish to **PyPI** and create a **GitHub release**. For the full release process, see [`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md). --- _Everything below this line will be the GitHub release body._ --- ## [0.0.6](langchain-ai/deepagents@deepagents-acp==0.0.5...deepagents-acp==0.0.6) (2026-04-18) ### Features * Add Opus 4.7 and Baseten to demo agent ([langchain-ai#2787](langchain-ai#2787)) ([bfb16a6](langchain-ai@bfb16a6)) ### Bug Fixes * Restore passing tests after acp v0.9 schema bump ([langchain-ai#2813](langchain-ai#2813)) ([29a351a](langchain-ai@29a351a)) --- _Everything above this line will be the GitHub release body._ --- > [!NOTE] > A **New Contributors** section is appended to the GitHub release notes automatically at publish time (see [Release Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline), step 2). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mason Daugherty <github@mdrxy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore test coverage for the ACP config-option wrapper compat added in #2700. When #2811 unbound
agent-client-protocolto v0.9.0 (which dropped theSessionConfigOptionwrapper), every.root.<attr>assertion intest_model_switching.pystarted raisingAttributeErroronmain.