Skip to content

test(s3): stop skipping DROP TABLE coverage on httpfs - #350

Merged
Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-s3-drop-table-test-coverage
Nov 19, 2026
Merged

Xuanwo merged 1 commit into
mainfrom
xuanwo/fix-s3-drop-table-test-coverage

Conversation

@Xuanwo

@Xuanwo Xuanwo commented Nov 19, 2026

Copy link
Copy Markdown
Member

Problem

test/sql/s3_drop_table_minio.test installed and loaded httpfs before exercising DROP TABLE through a TYPE LANCE secret. On the development version hash the httpfs download returns HTTP 404, and DuckDB SQLLogicTest treats an HTTP error message as a default skip. The test therefore reported success after running zero S3 statements, leaving DROP TABLE on S3 directory namespaces uncovered.

Change

Remove the unused INSTALL httpfs and LOAD httpfs statements. The test uses only a TYPE LANCE secret; its CREATE SECRET, COPY, ATTACH, query, DROP TABLE, missing-dataset check, and DETACH operations do not depend on httpfs. All assertions and the LANCE_TEST_S3 / MinIO environment requirements remain unchanged.

Evidence

Using the release unittest built from a9d25e5 (the open #349 sync branch; that commit differs from base 6a423fc only in the duckdb submodule pin):

  • Before (6a423fc file): [SKIP_TEST] ... skip on error_message matching 'HTTP', 0 assertions.
  • After (948f646 file) against an isolated MinIO: All tests passed (8 assertions in 1 test case) with --emit-on-skip.

The eight assertions are CREATE SECRET, COPY to S3, ATTACH, the count query, DROP TABLE, the post-drop open error, DROP TABLE IF EXISTS, and DETACH.

Scope

Test-only. No extension, dependency, or CI changes. Base main at 6a423fc; head 948f646.

The MinIO DROP TABLE test installed and loaded httpfs even though it uses a TYPE LANCE secret. A dev-hash httpfs download 404 matches SQLLogicTest's default skip-on-HTTP behavior, so the file reported a pass while running zero S3 assertions. The Lance secret and all exercised S3 operations do not depend on httpfs.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

Removing the unused httpfs setup eliminates an unrelated download dependency that can skip the DROP TABLE scenario. The remaining operations use Lance's own storage and secrets, and all eight checks and the MinIO environment gate are preserved.

Source review covered lance-duckdb 948f646 with pinned DuckDB a1854c47. I did not rerun the MinIO scenario here because this environment has no built test runner or MinIO service.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Nov 19, 2026
@Xuanwo
Xuanwo merged commit c4db3cd into main Nov 19, 2026
13 checks passed
@Xuanwo
Xuanwo deleted the xuanwo/fix-s3-drop-table-test-coverage branch November 19, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants