Repository navigation
test(s3): stop skipping DROP TABLE coverage on httpfs - #350
Conversation
The MinIO DROP TABLE test installed and loaded httpfs even though it uses a TYPE LANCE secret. A dev-hash httpfs download 404 matches SQLLogicTest's default skip-on-HTTP behavior, so the file reported a pass while running zero S3 assertions. The Lance secret and all exercised S3 operations do not depend on httpfs.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Removing the unused httpfs setup eliminates an unrelated download dependency that can skip the DROP TABLE scenario. The remaining operations use Lance's own storage and secrets, and all eight checks and the MinIO environment gate are preserved.
Source review covered lance-duckdb 948f646 with pinned DuckDB a1854c47. I did not rerun the MinIO scenario here because this environment has no built test runner or MinIO service.
Problem
test/sql/s3_drop_table_minio.testinstalled and loadedhttpfsbefore exercisingDROP TABLEthrough aTYPE LANCEsecret. On the development version hash the httpfs download returns HTTP 404, and DuckDB SQLLogicTest treats anHTTPerror message as a default skip. The test therefore reported success after running zero S3 statements, leavingDROP TABLEon S3 directory namespaces uncovered.Change
Remove the unused
INSTALL httpfsandLOAD httpfsstatements. The test uses only aTYPE LANCEsecret; itsCREATE SECRET,COPY,ATTACH, query,DROP TABLE, missing-dataset check, andDETACHoperations do not depend on httpfs. All assertions and theLANCE_TEST_S3/ MinIO environment requirements remain unchanged.Evidence
Using the release
unittestbuilt froma9d25e5(the open #349 sync branch; that commit differs from base6a423fconly in theduckdbsubmodule pin):6a423fcfile):[SKIP_TEST] ... skip on error_message matching 'HTTP', 0 assertions.948f646file) against an isolated MinIO:All tests passed (8 assertions in 1 test case)with--emit-on-skip.The eight assertions are
CREATE SECRET,COPYto S3,ATTACH, the count query,DROP TABLE, the post-drop open error,DROP TABLE IF EXISTS, andDETACH.Scope
Test-only. No extension, dependency, or CI changes. Base
mainat6a423fc; head948f646.