Remove legacy IP extraction logic from context.RealIP method #2933
Merged
aldas merged 1 commit intolabstack:masterfrom Mar 31, 2026
Merged
Remove legacy IP extraction logic from context.RealIP method #2933aldas merged 1 commit intolabstack:masterfrom
aldas merged 1 commit intolabstack:masterfrom
Conversation
… it to LegacyIPExtractor IP extraction function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
+ Coverage 93.01% 93.07% +0.05%
==========================================
Files 43 43
Lines 4496 4506 +10
==========================================
+ Hits 4182 4194 +12
+ Misses 196 195 -1
+ Partials 118 117 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does not break the API contract, but it does introduce breaking changes in logic/behavior. But as promised - 31.03.2026 will be last day for potentially breaking stuff. I want to get this security related thing done.
Remove legacy IP extraction logic from context.RealIP method and move it to LegacyIPExtractor IP extraction function.
v4behavior can be restored with:but you should instead with proper trust options
For example:
Read https://echo.labstack.com/docs/ip-address