Skip to content

refactor(modules): standardize logger field name to LOGGER - #559

Open
ThanuH wants to merge 1 commit into
labsai:mainfrom
ThanuH:refactor/logger-field-names
Open

refactor(modules): standardize logger field name to LOGGER#559
ThanuH wants to merge 1 commit into
labsai:mainfrom
ThanuH:refactor/logger-field-names

Conversation

@ThanuH

@ThanuH ThanuH commented Jun 20, 2026

Copy link
Copy Markdown

Summary

This PR standardizes logger naming across six modules. By renaming private static final log fields to LOGGER to match the project-wide convention, we improve consistency and searchability throughout the codebase.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • ♻️ Refactoring (no functional changes)
  • 🔧 Chore (dependency updates, CI changes, etc.)

Related Issue

Closes #

Changes Made

  • Renamed private static final Logger log to private static final Logger LOGGER in the following files:
    • src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.java
    • src/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.java
    • src/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.java
    • src/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.java
    • src/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.java
    • src/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.java
  • Updated all internal logger method invocations (e.g., log.info to LOGGER.info) to reflect the name change.

How to Test

  1. Run the build and test suite locally: ./mvnw clean verify -DskipITs.
  2. Verify that the logger field in each of the listed files is named LOGGER.
  3. Confirm that all log calls use the updated LOGGER reference.

Checklist

  • My code follows the project's code style
  • I have added tests that prove my fix/feature works
  • Existing tests pass locally (./mvnw clean verify -DskipITs)
  • I have updated documentation if needed
  • My commit messages follow conventional commits
  • I have not committed any secrets, API keys, or tokens
  • This PR has a clear, focused scope (one concern per PR)

Summary by CodeRabbit

  • Refactor
    • Standardized logging conventions across internal modules to improve code consistency and maintainability.

Note: This release contains internal code improvements with no user-visible changes or new functionality.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 16172fcf-e528-4140-8319-ec2ebb48fd14

📥 Commits

Reviewing files that changed from the base of the PR and between bd1b859 and 8ae362a.

📒 Files selected for processing (6)
  • src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.java
  • src/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.java
  • src/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.java
  • src/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.java
  • src/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.java
  • src/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.java

📝 Walkthrough

Walkthrough

Six module classes rename their static logger field from log to LOGGER and update all corresponding logging call sites (warn, error, debug, errorf). No logic, message content, control flow, or public API is changed.

Changes

Logger Field Standardization

Layer / File(s) Summary
Logger field and call site rename
src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.java, src/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.java, src/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.java, src/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.java, src/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.java, src/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.java
Each file renames the static logger field from log to LOGGER and updates all corresponding log.warn(...), log.error(...), log.debug(...), and log.errorf(...) call sites to LOGGER.*. No message content or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Poem

🐰 From log to LOGGER, a hop and a skip,
Six files all tidied with one little flip.
The bunny approves of conventions held tight,
No logic disturbed, just the naming set right.
A spotless refactor, carrots all 'round! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: standardizing logger field names from 'log' to 'LOGGER' across multiple modules, which is the exact focus of this refactoring PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a mechanical refactor to standardize logger field naming in several backend modules by renaming private static final Logger log to LOGGER and updating corresponding call sites, improving consistency and searchability without changing runtime behavior.

Changes:

  • Renamed log logger fields to LOGGER in six module classes.
  • Updated all affected logging invocations to reference LOGGER.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.java Renames the static logger field to LOGGER and updates error logs in templating paths.
src/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.java Renames the static logger field to LOGGER and updates error/warn/debug logging calls.
src/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.java Renames the static logger field to LOGGER and updates error logging during condition conversion.
src/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.java Renames the static logger field to LOGGER and updates error logging in JSON parsing branch.
src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.java Renames the static logger field to LOGGER and updates warning logging on interruption.
src/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.java Renames the static logger field to LOGGER and updates error logging in expression parsing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants