refactor(modules): standardize logger field name to LOGGER - #559
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughSix module classes rename their static logger field from ChangesLogger Field Standardization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR is a mechanical refactor to standardize logger field naming in several backend modules by renaming private static final Logger log to LOGGER and updating corresponding call sites, improving consistency and searchability without changing runtime behavior.
Changes:
- Renamed
loglogger fields toLOGGERin six module classes. - Updated all affected logging invocations to reference
LOGGER.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.java | Renames the static logger field to LOGGER and updates error logs in templating paths. |
| src/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.java | Renames the static logger field to LOGGER and updates error/warn/debug logging calls. |
| src/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.java | Renames the static logger field to LOGGER and updates error logging during condition conversion. |
| src/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.java | Renames the static logger field to LOGGER and updates error logging in JSON parsing branch. |
| src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.java | Renames the static logger field to LOGGER and updates warning logging on interruption. |
| src/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.java | Renames the static logger field to LOGGER and updates error logging in expression parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This PR standardizes logger naming across six modules. By renaming private static final
logfields toLOGGERto match the project-wide convention, we improve consistency and searchability throughout the codebase.Type of Change
Related Issue
Closes #
Changes Made
private static final Logger logtoprivate static final Logger LOGGERin the following files:src/main/java/ai/labs/eddi/modules/nlp/InputParserTask.javasrc/main/java/ai/labs/eddi/modules/nlp/expressions/utilities/ExpressionProvider.javasrc/main/java/ai/labs/eddi/modules/rules/impl/RuleDeserialization.javasrc/main/java/ai/labs/eddi/modules/rules/impl/RulesEvaluationTask.javasrc/main/java/ai/labs/eddi/modules/rules/impl/conditions/ContextMatcher.javasrc/main/java/ai/labs/eddi/modules/templating/OutputTemplateTask.javalog.infotoLOGGER.info) to reflect the name change.How to Test
./mvnw clean verify -DskipITs.LOGGER.LOGGERreference.Checklist
./mvnw clean verify -DskipITs)Summary by CodeRabbit
Note: This release contains internal code improvements with no user-visible changes or new functionality.