Fix SQL injection in database_exists() - #823
Open
pctablet505 wants to merge 2 commits into
Open
Conversation
database_exists() built its existence-check query for postgresql, mysql and mssql by splicing the database name into the SQL text with %-string interpolation. A database name containing SQL metacharacters could inject arbitrary statements. Use bound parameters instead. Fixes kvesteri#760
pctablet505
marked this pull request as ready for review
July 17, 2026 12:47
Follows the repo's convention of recording fixes in the Unreleased section of CHANGES.rst with a reference to the issue number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
database_exists()builds its existence-check query for postgresql, mysql, and mssql by splicing the database name straight into the SQL text with%-string interpolation. A database name containing SQL metacharacters can inject arbitrary statements, as described in #760.This switches all three queries to use bound parameters instead of string interpolation, so the database name is always sent as data, never as part of the SQL text.
Added a regression test that captures what actually gets sent to the DBAPI and asserts the injection payload never appears in the SQL string.
Fixes #760.