linux: stop ignoring SIGCHLD process-wide - #1191
Merged
Merged
Conversation
Element set SIGCHLD to SIG_IGN on Linux to avoid zombie scanner processes. That makes the kernel auto-reap every child, so any code in the process that calls waitpid() gets ECHILD. yabridge spawns a wine helper while loading a bridged plugin and asserts on that failure, which crashed the scanner and the main app for every Windows plugin. The scanner is launched through juce::ChildProcessManager, which polls and reaps its children itself, so the workaround is no longer needed. Fixes #1149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element set SIGCHLD to SIG_IGN on Linux to avoid zombie scanner processes. That makes the kernel auto-reap every child, so any code in the process that calls waitpid() gets ECHILD. yabridge spawns a wine helper while loading a bridged plugin and asserts on that failure, which crashed the scanner and the main app for every Windows plugin.
The scanner is launched through juce::ChildProcessManager, which polls and reaps its children itself, so the workaround is no longer needed.
Fixes #1149