Housekeeping: Add Some Memory Safety Clamps - #1182
Merged
Merged
Conversation
Plugin-reported latency and delay compensation size the per-channel delay buffers in the graph builder with no upper bound, so a bogus value could allocate gigabytes per connection. Clamp both to Processor::maxLatencySamples and log the node when that happens. Delay compensation restored from a session was converted to samples before the node was prepared, with a sample rate of zero, and never recomputed. Recompute it in prepare(). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The rendering buffers were fixed at 4096 samples, so any device or host block larger than that wrote past the end of each channel. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ConfigFor Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Formats were registered in prepareToPlay, but plugin state is now restored before the node is prepared, so the saved file could not be opened and was silently dropped on session load. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Blocks are buffered to an image and carry a shadow effect, so a custom size read from a session with no upper bound could allocate two enormous bitmaps. Clamp to 8192 x 8192. The async embed message held a reference to the block and one of its members; use a SafePointer so a block deleted before delivery is skipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.