Skip to content

fix: Makefile - build-testkube-cli target - rebuild CLI if binary already exist - #8424

Open
tkonieczny wants to merge 1 commit into
mainfrom
fix-makefile-cli-phony-go-build
Open

tkonieczny wants to merge 1 commit into
mainfrom
fix-makefile-cli-phony-go-build

Conversation

@tkonieczny

@tkonieczny tkonieczny commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Fix for:

$ make build-testkube-cli
make: Nothing to be done for `build-testkube-cli'.

not running go build even if binary is outdated

@tkonieczny
tkonieczny requested a review from a team as a code owner September 29, 2026 16:22
@testkubebot

testkubebot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Testkube GitHub Integration

Review based on commit 3d4a5be.

All tests and quality gates passed.


Phase Status
Test Workflow Execution ✅ Passed
Quality Gate ✅ Passed

7 workflows executed

✅ lint-go passed in 5m12s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:27:50 UTC

✅ lint-proto passed in 17s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:22:55 UTC

✅ integration-tests passed in 7m43s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:30:21 UTC

✅ unit-tests passed in 4m19s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:26:57 UTC

✅ verify-crds passed in 2m13s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:24:51 UTC

✅ verify-protobuf passed in 17s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:22:55 UTC

✅ lint-pr passed in 16s
🚀 29. Sep. 2026 - 16:22:37 UTC / 🏁 29. Sep. 2026 - 16:22:54 UTC


Manage this Integration

@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Build system makefile target declaration fix.

The PR appears safe to merge.

Summary

The PR makes both CLI build targets run go build even when their binaries already exist. No merge-blocking issue was established.

Reviews (1) · Last reviewed commit: "Makefile - build-testkube-cli - (re)buil..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant