Repository navigation
Conversation
Signed-off-by: Jeff Spahr <spahrj@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor Report for @jeffspahr
|
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful MLMD ownership lookup can authorize an artifact even when its standard storage key explicitly names another namespace. For keys under the configured
private-artifacts/<namespace>/prefix, reject a mismatch with the caller's authorized namespace before consulting MLMD or reading storage. The check covers encoded namespace aliases and namespace directory roots in both direct and proxied artifact paths.Custom roots without that prefix retain their existing metadata-based behavior. This is bounded protection for canonical keys; storage authority for custom roots remains separate work.
Verification: 59 focused validator and HTTP/protobuf integration tests passed. Frontend server lint, TypeScript typecheck, Prettier checks, and
git diff --checkpassed. The integration test verifies that a tracked foreign-prefix object is denied before MLMD or object storage is contacted, while a matching-prefix object remains readable.Signed-off-by: Jeff Spahr spahrj@gmail.com