feat: allow source patches to be placed in user-defined output groups#46
Open
kormide wants to merge 1 commit into
Open
feat: allow source patches to be placed in user-defined output groups#46kormide wants to merge 1 commit into
kormide wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it's enough to put patches for source files into a single output group. In a build graph there may be different categories of patches and how they're dealt with. For example, you might want patches for a vendored bundle to be automatically applied on CI, but for a snapshot test you would want someone to carefully review the diff before committing.
This adds a mechanism to differentiate those categories via custom output groups. I don't think diff.bzl should go as far as defining what those categories are, so this seems like the appropriate level for customization.