Skip to content

[AUTOMATION] fix(clawpatch): address daily finding#240

Open
michiosw wants to merge 1 commit into
mainfrom
fix/clawpatch-daily-20260601T071415Z
Open

[AUTOMATION] fix(clawpatch): address daily finding#240
michiosw wants to merge 1 commit into
mainfrom
fix/clawpatch-daily-20260601T071415Z

Conversation

@michiosw
Copy link
Copy Markdown
Contributor

@michiosw michiosw commented Jun 1, 2026

Where We Are

The guard dashboard can show the wrong error after a session switch. If session A starts loading, the user switches to session B, and A fails later, A's error still replaces the visible state while B is selected.

Where We Want To Go

Only the selected session should be allowed to update the dashboard state. A stale failure from an old session must be ignored so the error banner still matches the session on screen.

How do we get there

This change adds the same selectedRef.current !== id guard to the loadEvents error path that already exists on the success path in web/guard-dashboard/src/App.tsx. Validation passed with go test ./... on rerun after one unrelated flaky timeout in internal/guard/judge, go vet ./..., npm exec --yes --package pnpm@10.0.0 -- pnpm install --frozen-lockfile, npm exec --yes --package pnpm@10.0.0 -- pnpm --dir web/guard-dashboard typecheck, and git diff --check.

Copy link
Copy Markdown
Contributor Author

michiosw commented Jun 1, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 1, 2026

Greptile Summary

This PR updates dashboard event loading error handling for stale session requests. The main change is:

  • Ignore fetchEvents failures when the selected session has changed before the request rejects.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The new rejection guard matches the existing success-path guard for stale event requests.
  • Active session event-fetch failures still surface through the dashboard error message.

Reviews (1): Last reviewed commit: "fix(clawpatch): address daily finding" | Re-trigger Greptile

@michiosw michiosw force-pushed the fix/clawpatch-daily-20260601T071415Z branch from 272642c to 0f09bad Compare June 1, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant