[AUTOMATION] fix(clawpatch): address daily finding#240
Open
michiosw wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR updates dashboard event loading error handling for stale session requests. The main change is:
Confidence Score: 5/5This looks safe to merge.
Reviews (1): Last reviewed commit: "fix(clawpatch): address daily finding" | Re-trigger Greptile |
272642c to
0f09bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Where We Are
The guard dashboard can show the wrong error after a session switch. If session A starts loading, the user switches to session B, and A fails later, A's error still replaces the visible state while B is selected.
Where We Want To Go
Only the selected session should be allowed to update the dashboard state. A stale failure from an old session must be ignored so the error banner still matches the session on screen.
How do we get there
This change adds the same
selectedRef.current !== idguard to theloadEventserror path that already exists on the success path inweb/guard-dashboard/src/App.tsx. Validation passed withgo test ./...on rerun after one unrelated flaky timeout ininternal/guard/judge,go vet ./...,npm exec --yes --package pnpm@10.0.0 -- pnpm install --frozen-lockfile,npm exec --yes --package pnpm@10.0.0 -- pnpm --dir web/guard-dashboard typecheck, andgit diff --check.