Repository navigation
Fix, build and test the energy profiler daemon - #350
Open
ethan-puyaubreau wants to merge 7 commits into
Open
ethan-puyaubreau wants to merge 7 commits into
ethan-puyaubreau wants to merge 7 commits into
Conversation
Contributor
|
you can even use c++20 and jthread now |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #300: no target builds the daemon, and it does not compile (
std::chrono::durationneeds template arguments).std::chrono::nanoseconds, so milliseconds, microseconds or seconds convert to it implicitly.kp_energy_profiler_daemon.std::jthread:stop()requests a stop that wakes the thread instead of waiting up to a full interval, and destroying a running daemon stops it instead of callingstd::terminate. ThreadSanitizer reported a data race onrunning_before.steady_clock:high_resolution_clockissystem_clockin libstdc++.Tested on my fork against Kokkos 5.0.2 and develop.