Skip to content

Fix normal coloring for odometry scans and keyframes - #321

Merged
koide3 merged 1 commit into
koide3:masterfrom
noelex:dev
Aug 17, 2026
Merged

Fix normal coloring for odometry scans and keyframes#321
koide3 merged 1 commit into
koide3:masterfrom
noelex:dev

Conversation

@noelex

@noelex noelex commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix normal-based coloring for odometry scans and keyframes in the standard viewer.

Problem

This fixes a regression introduced during the intensity display refactor in #281.

The odometry NORMAL color mode uploads normal-derived colors through
PointCloudBuffer::add_color(), but the scan shader was configured to use
VERTEX_COLORMAP. As a result, it read the colormap attribute used for
intensity rendering instead of the vertex color attribute.

Odometry keyframes also did not upload normal-derived vertex colors, and their
NORMAL mode continued to use rainbow coloring.

Changes

  • Use VERTEX_COLOR for odometry scan normal coloring.
  • Upload normal-derived vertex colors for odometry keyframes.
  • Use VERTEX_COLOR for keyframes when normals are available.
  • Preserve the existing Flat/Rainbow fallback when normals are unavailable.

Testing

  • git diff --check
  • cmake --build build/glim --target standard_viewer -j2

@koide3

koide3 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Thank you!

@koide3
koide3 merged commit bba7bf4 into koide3:master Aug 17, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants