fix(kyc): close gate before redirect modal

[LohdGordon]

Closes #1027

This closes the KYC-required gate before opening KYCRedirectModal after successful session creation, preventing overlapping dialogs and focus conflicts while preserving verification URL handling.

Checks:

• ESLint passes
• Typecheck could not fully run because required dependencies are unavailable.

Summary by CodeRabbit

• Bug Fixes
  • The KYC dialog now closes before the verification redirect modal opens.

[almanax-ai]

Plan expired

Your subscription has expired. Please renew your subscription to continue using CI/CD integration and other features.

[drips-wave]

@LohdGordon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[vercel]

@Emmycivity is attempting to deploy a commit to the kindfi Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 53ae7727-4aed-4962-8ad4-7ad2d4b540aa

📥 Commits

Reviewing files that changed from the base of the PR and between 8b94f0a and e3217ef.

📒 Files selected for processing (1)

• apps/web/components/sections/kyc/kyc-required-gate.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

After successful KYC session creation with a verification URL, KycRequiredGate closes its dialog before storing the URL and opening the redirect modal.

Changes

KYC redirect flow

Layer / File(s)	Summary
Close gate before redirect apps/web/components/sections/kyc/kyc-required-gate.tsx	When session creation succeeds with a verification URL, the gate closes before the redirect modal opens. The verification URL handling remains in place.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e3217

The change performs the intended gate close before showing the redirect flow, with no supported merge-blocking risk identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to e3217

The change closes the KYC gate before opening the verification redirect dialog. It does not appear to change who can create a verification session or where the resulting link comes from. Some caller and runtime behavior remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed path affects the browser handoff after a KYC session is created, not the server’s authority to create a session for an authenticated user.

Trust Boundaries and Controls

• inferred — The external-navigation sink still receives the URL returned by the session endpoint. The modal does not itself restrict destination hosts, but neither that sink nor its URL source changes in this PR.

Resilience and Maintainability Implications

• observed — A failed session response leaves the gate on its error path; modal countdown timers are cleared when the effect closes or unmounts.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: closing the KYC gate before opening the redirect modal.
Linked Issues check	✅ Passed	Consider the implementation complete for issue [#1027]. In handlePrimary, the successful-session branch calls onOpenChange(false) before setVerificationUrl(result.verificationUrl) and `setShowRe…
Out of Scope Changes check	✅ Passed	The reviewed change is limited to apps/web/components/sections/kyc/kyc-required-gate.tsx. It changes the successful KYC session flow required by [#1027]. No unrelated implementation, test, or docume…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A session finds its URL,
The KYC gate closes first.
Then the redirect modal opens,
The next step comes into view.
One dialog yields its place,
And the flow moves on.}

_{Comment @coderabbitai help to get the list of available commands.}