Skip to content

fix(milestones): use indices as React keys - #1080

Closed
Adamsonoladipupo wants to merge 1 commit into
kindfi-org:developfrom
Adamsonoladipupo:fix/1031-milestone-index-keys
Closed

Adamsonoladipupo wants to merge 1 commit into
kindfi-org:developfrom
Adamsonoladipupo:fix/1031-milestone-index-keys

Conversation

@Adamsonoladipupo

@Adamsonoladipupo Adamsonoladipupo commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #1080

Updated milestone renderers to use their existing array indices as React keys.

Changes

  • Updated milestones-tab.tsx to use key={index} for milestone rendering.
  • Updated milestone-reviews-panel.tsx to use key={index} for milestone rendering.
  • Preserved existing index-based milestone interactions and behavior.
  • Left tutorial-card.tsx unchanged.
  • Made no unrelated refactors or behavior changes.

Verification

  • Reviewed the final diff to confirm only the intended milestone key changes were made.
  • Confirmed tutorial-card.tsx was not modified.
  • Ran the applicable project checks successfully.

Closes #1080

Summary by CodeRabbit

  • Refactor
    • Updated internal milestone list rendering. This change does not alter the milestone information or functionality available in the app. No user-facing changes are included in this update.

Use milestone array indices as React keys in the milestone tab and milestone reviews panel, since milestone descriptions and amounts are not unique.

Preserve existing index-based milestone interactions and leave tutorial-card.tsx unchanged.
@almanax-ai

almanax-ai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Plan expired

Your subscription has expired. Please renew your subscription to continue using CI/CD integration and other features.

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

@Adamsonoladipupo is attempting to deploy a commit to the kindfi Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Adamsonoladipupo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 540d5851-4315-4c5a-97d3-bb4e22f99395

📥 Commits

Reviewing files that changed from the base of the PR and between 8b94f0a and c3e35b4.

📒 Files selected for processing (2)
  • apps/web/components/sections/projects/manage/escrow/tabs/milestones-tab.tsx
  • apps/web/components/sections/projects/manage/milestone-reviews/milestone-reviews-panel.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Both milestone renderers now use each milestone’s array index as its React key. The escrow milestones tab also removes an import used to build the previous keys.

Changes

Milestone React keys

Layer / File(s) Summary
Use array indices for milestone keys
apps/web/components/sections/projects/manage/escrow/tabs/milestones-tab.tsx, apps/web/components/sections/projects/manage/milestone-reviews/milestone-reviews-panel.tsx
Both renderers use the milestone array index as the React key. The escrow tab removes the import used to distinguish single-release milestones when building keys.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: bran18

Merge Risk: ⚪ Minimal · up to c3e35

No concrete user-visible regression from the milestone key changes is established, so the PR appears ready to merge subject to normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue [#1031]. milestones-tab.tsx and milestone-reviews-panel.tsx now use the milestone array index as the React key. The summary reports that existing index-based interactions…
Out of Scope Changes check ✅ Passed The changes are limited to the two milestone renderers named by issue [#1031]. They replace composite milestone keys and remove the unused isSingleReleaseMilestone import. No unrelated refactor or b…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: using array indices as React keys for milestone renderers.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Milestone lists march in line
Each index marks a place in time
Old keys drift out of view
Two renderers share the cue
Small changes keep the keys aligned

Comment @coderabbitai help to get the list of available commands.

@Adamsonoladipupo
Adamsonoladipupo deleted the fix/1031-milestone-index-keys branch September 26, 2026 16:38
@Adamsonoladipupo
Adamsonoladipupo restored the fix/1031-milestone-index-keys branch September 26, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant