fix(openai): apply ReasoningEffort in applyOpenAIConfig#1959
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for propagating a new ReasoningEffort configuration option into OpenAI chat completion params.
Changes:
- Extend
applyOpenAIConfigto mapOpenAIConfig.ReasoningEffortontoopenai.ChatCompletionNewParams. - Add a unit test case verifying
ReasoningEffortis applied.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go/adk/pkg/models/openai_adk.go | Applies ReasoningEffort from config onto OpenAI request params. |
| go/adk/pkg/models/openai_adk_test.go | Adds a test ensuring ReasoningEffort is set when configured. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The Copilot suggestions are not applicable here.. |
ReasoningEffort was set in OpenAIConfig but never forwarded to the ChatCompletionNewParams, so o1 model reasoning settings were silently ignored. Pass it through the same as the other config fields. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/openai-reasoning-effort
branch
from
fbf3fca to
7053ac4
Compare
EItanya
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReasoningEffort was set in OpenAIConfig but never forwarded to ChatCompletionNewParams, so o1 model reasoning settings were silently ignored.
This adds the missing field assignment in applyOpenAIConfig, matching the pattern used for other config fields.
Fixes: ReasoningEffort is now passed through to the OpenAI API call.