Repository navigation
perf(chat): Chat loads its dialogs and subpages when they open - #2623
Merged
Merged
Conversation
4 of 6 tasks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat currently downloads every dialog and secondary destination before its list, conversation and composer are usable. Load those destinations through
importOnDemand()when they open, with immediate localized loading feedback and an inline retry after a failed download. Info retains its state when closed; deferred SSR seeds are discarded if a live invalidation arrives during download.Narrow capability-contract imports remove YAML from the static graph. Zod remains because the browser uses it to validate API responses, messages and live events. Rare destinations render the same loading surface on the server and first client render, then consume their authorized SSR seed. Chat response compression stays unchanged.
Before / after
Same isolated production setup, fictional 3-chat fixture with 40 messages in the linked chat; phone Chromium 390×844@3, CPU 4×, RTT 150 ms, download 200,000 B/s. Times are medians of three runs on the shared VM. Each stack was cleaned up before the next measurement.
The sibling perf-baseline harness fix was not available, so these measurements reuse the report's production runtime, probe and phone profile. Deterministic manifest byte counts are the primary regression signal; VM timing varies. No shared island-budget mechanism exists on origin/main: the smallest Chat-local guard checks the actual production entry ≤500 KiB, its static closure ≤1280 KiB, and the static graph for dialog/subpage/YAML/dictation/picker regrowth.
Verification and parity
ChatWorkspace.render.test.tsx(37),pwa.page.render.test.ts(9).git diff --checkpass.No unrelated layout, history, reload, authentication or compression changes. No issue required for this single-commit performance change.