fix(browser): ignore transient CDP decode errors#566
fix(browser): ignore transient CDP decode errors#566cbusillo wants to merge 3 commits intojust-every:mainfrom
Conversation
Treat chromiumoxide Message deserialization failures as transient browser handler errors so normal navigation does not clear the active page. Add regression coverage for the handler path and BrowserManager local navigation in headed and headless modes.
Prevent debug assertion panic by tagging background HistoryCells inserted via the prelude helper with the background tag instead of prelude. This keeps background events on the background code path while preserving the synthetic key ordering used for top-of-request inserts.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7916c09e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn headed_internal_browser_can_open_local_http_server() { | ||
| assert_manager_can_open_local_http_server(false).await; |
There was a problem hiding this comment.
The new headed test always executes assert_manager_can_open_local_http_server(false), which requires launching Chrome without headless mode. In environments where DISPLAY/Wayland is unavailable (common for CI and dev containers), browser launch fails before navigation, so cargo test -p code-browser fails due to environment rather than a product regression. Please gate this test (or skip it) when no display server is present.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing