Skip to content

fixed tests, added last-value-printing / publishing of execution results - #62

Merged
JohanMabille merged 13 commits into
jupyter-xeus:mainfrom
DerThorsten:io
Mar 10, 2026
Merged

JohanMabille merged 13 commits into
jupyter-xeus:mainfrom
DerThorsten:io

Conversation

@DerThorsten

Copy link
Copy Markdown
Member
  • fixed tests, mostly a missing flush_channels
  • drastically improved last value printing

@DerThorsten
DerThorsten marked this pull request as draft March 10, 2026 09:35
@DerThorsten
DerThorsten marked this pull request as ready for review March 10, 2026 10:23
@JohanMabille
JohanMabille merged commit 0462359 into jupyter-xeus:main Mar 10, 2026
5 checks passed
@thomasjm

Copy link
Copy Markdown

Hi @DerThorsten,

I think this caused some big regressions affecting all releases containing this commit (0.9.1, 0.9.2, 0.10.0, 0.10.1). It makes code as simple as the following stop working, printing nil instead of 3:

local n = 3
print(n)

I made a small repro setup at https://github.com/thomasjm/xeus-lua-repro. This uses Nix to build xeus-lua both before and immediately after this change, to show that it causes the regression. Any chance you could you take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants