fix: correct login error, validate CLI flags, and migrate CI to go-cli blueprint - #1
Open
o5carm wants to merge 2 commits into
Open
fix: correct login error, validate CLI flags, and migrate CI to go-cli blueprint#1o5carm wants to merge 2 commits into
o5carm wants to merge 2 commits into
Conversation
…ive flags - Fix json.Marshal(resp.Body) to io.ReadAll(resp.Body) in Login() - Add 30s timeout to login HTTP client - Mark pinned/disabled/enabled flags as mutually exclusive in alias list - Update Go version to 1.26.5
…dagger-blueprints - Remove local .dagger/ Go module (legacy) - Set blueprint to github.com/o5carm/dagger-blueprints/go-cli@df6f692 - Update ci.yaml: single verify + build jobs using blueprint - Update release.yaml: single release job using blueprint - Remove redundant lint/format/publish jobs (handled by blueprint toolchain) All workflows now call functions exposed by the go-cli blueprint: - verify (repository + Go quality checks) - build (multi-platform binaries) - release (semantic-release + GitHub assets)
o5carm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
json.Marshal(resp.Body)toio.ReadAll— the previous implementation serialized the*http.Responsetype instead of reading its contents, producing empty or misleading error messages on login failure.--active,--disabled, and--pageas mutually exclusive flags, as per API documentation.CI Refactor
.dagger/, 13 Go files) with thego-cliblueprint fromgithub.com/o5carm/dagger-blueprints/go-cli@df6f692ci.yaml: singleverifyjob (repository + Go quality checks) →buildjob (multi-platform binaries)release.yaml: singlereleasejob (semantic-release + GitHub assets upload)Blueprint Usage
The
go-cliblueprint exposes:verify— repository validation + Go lint/testbuild(name, packages, platforms)— multi-platform binariesrelease(name, packages, repositoryUrl, dryRun)— semantic-release + asset upload