Repository navigation
feat(cg): use commission flag for new workers - #130
Merged
Merged
Conversation
zxh326
changed the title
The quay.io/minio/minio:latest manifest no longer resolves, leaving the MinIO setup step waiting for readiness until it times out. Use juicedata/minio:latest for the existing e2e fixture.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Commission can be incorrectly enabled for non-EE images or combined with an explicitly configured group-backup option.
3 open findings
What changed in this PR
Adds version-aware commission handling for new cache-group workers while retaining group-backup compatibility.
Changes:
- Selects temporary join flags based on worker version.
- Removes
commissionwhen decommissioning workers. - Updates option filtering, documentation, and E2E MinIO image.
| File | Description |
|---|---|
api/v1/cachegroup_types.go |
Documents join behavior and requirements. |
config/samples/v1_cachegroup.yaml |
Updates sample guidance. |
internal/controller/cachegroup_controller.go |
Determines when workers require a join option. |
pkg/builder/cache_group_pod.go |
Generates commission flags and decommission commands. |
pkg/builder/job.go |
Excludes lifecycle flags from job mount options. |
pkg/common/common.go |
Defines the minimum commission version. |
test/e2e/config/minio.yaml |
Changes the E2E MinIO image. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zwwhdls
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.