Fix annotate-specification-links crash, CI trigger path, and UTF-8 file loading - #1192
Merged
jdesrosiers merged 1 commit intoSep 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1190
Summary of Changes
This PR addresses three related tooling, cross-platform, and CI issues identified on the
unifybranch:Fix
TypeErrorand external template lookups invalidation/annotate-specification-links:dialecttoint(dialect)inapplicable_dialectssochecker.dialect_appliescompares numeric versions against integers rather than strings.rfc,iso,ecma262,perl5) directly fromURLS["external"], which avoids false-positive missing template errors on future dialect placeholders ("compatibility": "9999").each = dict(each))..as_posix()for emitted annotation file paths to guarantee forward slashes across all operating systems.Fix disconnected CI path filter in
.github/workflows/show_specification_annotations.yml:pathsfrom'tests/**'to'validation/tests/**'so pull requests modifying the unified test suite properly trigger specification link checks.Cross-platform UTF-8 file loading:
encoding="utf-8"topath.read_text()andpath.open()incheck_validation_suite.pyandannotate-specification-linksto preventUnicodeDecodeErroron Windows environments defaulting tocp1252.Verification
python validation/annotate-specification-linksruns end-to-end and exits cleanly with code 0, emitting all notices with POSIX paths.python validation/check_validation_suite.pypasses all 11 test suites across all 114 test files on Windows and POSIX systems.python -m py_compile validation/annotate-specification-links validation/check_validation_suite.pyconfirms no syntax errors.