Add NTLM authentication for PagerDuty proxies - #1772
Merged
Conversation
jertel
requested changes
Jul 30, 2026
jertel
left a comment
Owner
There was a problem hiding this comment.
Thanks for the submission. I have a few comments.
Contributor
Author
|
Validation completed after addressing the review feedback:
The integration test exercises the NTLM |
Removed TBD entries and updated version 2.32.0 with new features.
jertel
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds optional NTLM authentication for HTTPS proxy connections made by the PagerDuty alerter.
PagerDuty endpoints are HTTPS, so proxy authentication occurs while the client establishes the HTTP
CONNECTtunnel.HTTPProxyAuthonly adds Basic proxy credentials and cannot complete the NTLM challenge-response exchange described in discussion #1762.This change:
pagerduty_proxy_loginandpagerduty_proxy_pass;pagerduty_proxy;Example:
The password is not logged. The implementation passes an in-memory NT hash to the NTLM adapter because its underlying
ntlm-authlibrary otherwise asks OpenSSL for disabled MD4 support.Validation
make test-docker1131 passed, 4 skipped-Welastalert/alerters/pagerduty.py: 92%45 passedgit diff --check: passedDockerfilebuild: passedpip check:No broken requirements foundThe simulated proxy test uses real loopback sockets rather than HTTP mocks. It:
CONNECTrequest;202 Accepted.No corporate proxy was available during development. The protocol and application flow were therefore validated against the deterministic local NTLM proxy above. A real enterprise-proxy smoke test can be added later if maintainers request it.
Checklist
make test-dockerwith my changes.Questions or Comments
CONNECTexchange and tunneled HTTPS request over real sockets. I cannot post outputs from my corporate/work network