fix: update selector for newegg product price#3221
Merged
Conversation
Using this updated selector fixes the MAX_PRICE_* feature in Newegg
jef
approved these changes
Feb 17, 2025
Owner
|
Very good! Thank for fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the MAX_PRICE_* feature doesn't work with Newegg, because it's using the wrong selector. This change updates the selector so that the product price is correctly selected. I've also changed the
outOfStockselector to.product-buybecause.product-inventorydoes not exist on the product page.Testing
New dependencies