Jbtm 4039#207
Conversation
|
[EDIT] I removed changes to the run parameters as request by the reviewers. |
| // set the slot size, making sure it's a sensible multiple | ||
| int threadCount = getThreadCountFromProperties(THREADS); | ||
| configBean.setNumberOfSlots(roundUp(256, threadCount)); | ||
| configBean.setBackingSlotsClassName(DiskSlots.class.getName()); |
There was a problem hiding this comment.
I suppose that InfinispanSlots is the BackingSlotsClassName to test, isn't it?
| try { | ||
| // clean up the storage otherwise it may interfere with the next run | ||
| if (!purgeFiles(Paths.get(STORE_DIR).toFile())) { | ||
| System.err.printf("problem removing slot store file storage (%s)%n", STORE_DIR); | ||
| } | ||
| } catch (Exception e) { | ||
| System.err.printf("Warn: problem cleaning the object store (%s): %s%n", STORE_DIR, e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Cannot this code be replaced with an invocation to cleanStore?
| try { | ||
| // clean up the storage otherwise it may interfere with the next run | ||
| if (!purgeFiles(Paths.get(storeDir).toFile())) { | ||
| System.err.printf("problem removing slot store file storage (%s)%n", storeDir); | ||
| } | ||
| } catch (Exception e) { | ||
| System.err.printf("Warn: problem cleaning the object store (%s): %s%n", storeDir, e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Cannot this code be replaced with an invocation to cleanStore?
| try { | ||
| // clean up the storage otherwise it may interfere with the next run | ||
| if (!purgeFiles(Paths.get(storeDir).toFile())) { | ||
| System.err.printf("problem removing slot store file storage (%s)%n", storeDir); | ||
| } | ||
| } catch (Exception e) { | ||
| System.err.printf("Warn: problem cleaning the object store (%s): %s%n", storeDir, e.getMessage()); | ||
| } |
There was a problem hiding this comment.
Cannot this code be replaced with an invocation to cleanStore?
| // Sometimes it is useful to run the benchmark directly from an IDE: | ||
| Options opt = new OptionsBuilder() | ||
| .include(InfinispanSlotsStoreBenchmark.class.getSimpleName() + ".testWriteThroughCache") | ||
| .include(BM_CLASS_NAME + ".testWriteThroughCache") |
There was a problem hiding this comment.
Shouldn't this be testInfinispanStore?
| int threadCount = defaultThreadCount; | ||
| String jmhArgs = System.getenv(JMHARGS_ENV); | ||
|
|
||
| if (jmhArgs !=null) { |
There was a problem hiding this comment.
Sorry...nitpicking:
| if (jmhArgs !=null) { | |
| if (jmhArgs != null) { |
mmusgrov
force-pushed
the
JBTM-4039
branch
2 times, most recently
from
28f11c4 to
9001bab
Compare
…he stores before each test.
|
Thanks for the review, some good catches. I'll wait for the test runs to complete, might be tomorrow now, before merging. |
3 participants
https://redhat.atlassian.net/browse/JBTM-4039
The fix for the SlotStore performance failure with 1600 threads is i) to set the number of slots to be large enough to handle the number of benchmark threads creating transactions and ii) to also clean the stores before running each benchmark.