Repository navigation
fix: security - upgrade markdown-it to 15.0.3 and vite to 8.3.4 - #560
Merged
Merged
Conversation
Direct markdown-it moves from 15.0.1 to 15.0.3. Vitest's vite dependency refreshes from 8.2.1 to 8.3.4. The fumanchu copy stays on markdown-it 15.0.2. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 515 515
Branches 144 144
=========================================
Hits 515 515 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Re-run pnpm benchmark and record the JavaScript comparison, including markdown-it 15.0.3 and marked 18.0.12, next to the native tables. Co-authored-by: Jared Wray <me@jaredwray.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Security fix. Existing Vitest coverage covers this upgrade; no new tests. The README JavaScript benchmark tables are refreshed for markdown-it 15.0.3.
Packages
markdown-it
15.0.1→15.0.3Direct devDependency specifier
^15.0.1→^15.0.3. The lockfile resolves that copy to15.0.3(published 2026-10-16, outside the 7-dayminimumReleaseAgewindow). No override and nominimumReleaseAgeExclude.That copy also pulls
argparse@3.0.3andentities@8.1.0. The3.0.0and8.0.0copies stay for markdown-it15.0.2.Advisories fixed by
15.0.3:typographer: true). Fixed in 15.0.2.htmlis enabled. Fixed in 15.0.3.vite
8.2.1→8.3.4Dev-only, through
vitest@5.0.0(vite@^6.4.0 || ^7.0.0 || ^8.0.0) and@vitest/mocker. Lockfile refresh only. Vite is not a direct dependency, and nothing pins an exact vulnerable version, so there is no override.8.3.5(published 2026-10-21) is still inside the 7-day cooldown.8.3.4(published 2026-10-08) is the newest release outside that window and is already past the8.3.3fix. NominimumReleaseAgeExclude.Vite
8.3.4depends onrolldown@1.2.14.tsdownstill resolvesrolldown@1.2.7.Advisory:
launch-editorfs.existsSync()existence check can be bypassed on Windows, which can lead to OS command injection. Affected on the 8.2 line through8.2.3and on the 8.3 line through8.3.2. Fixed in vite8.3.3(and8.2.4on the previous line).README benchmarks
pnpm benchmarkwas run against markdown-it 15.0.3 and marked 18.0.12. The JavaScript comparison tables inREADME.mdnow record that run (October 26, 2026, Node.js v22.22.2). On the minimal profile, cached Writr sync is 99K ops/sec, marked is 40K ops/sec, and markdown-it 15.0.3 is 28K ops/sec. The September 28 writr-rs tables are unchanged.Left on purpose
markdown-it@15.0.2via@jaredwray/fumanchu@4.7.4(markdown-it@^15.0.2). That copy stays until a fumanchu release that depends on15.0.3. fumanchu main already has15.0.3. This PR does not bump fumanchu, ecto, or docula.minimumReleaseAgeExcludeentries forzod@4.6.6andzod@4.6.7are unchanged.Publishing an npm release after merge is a separate decision. This PR does not publish, release, or deploy.