Repository navigation
fix: pin patched releases for high and critical advisories - #1740
Merged
Merged
Conversation
The lockfile now uses proxy-addr 2.0.8, undici 7.30.0, minimatch 10.2.6, and brace-expansion 1.1.21 and 5.0.12. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3612 3612
Branches 809 822 +13
=========================================
Hits 3612 3612 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Security fix. Transitive dependency pins for High and Critical advisories.
No new test was added. The change is a lockfile pin. The existing suite covers the packages that load these dependencies.
Pins
^2.0.7.@cacheable/net. This release includes the 8.x fix (8.10.2).^10.2.2.^1.1.7.^5.0.8.>= 4.59.1. The Socket row still says 4.50.0. That row is stale.^10.29.0. The vulnerable range stops at 10.24.0. CVE-2026-30952 is fixed in 10.25.0.tar,axios, and@isaacs/brace-expansionare not in this lockfile. This pull request does not add an override for an absent package. A forced major upgrade can break a later install.express 5.2.1 now resolves
body-parser2.3.0. The express range is^2.2.1.cacheable-requestalready depends onbody-parser^2.3.0.qs6.14.1 left the tree withbody-parser2.2.2.http-cache-semantics 4.2.0 (CVE-2026-93748)
No safe fix exists. This pull request does not change the dependency.
Version 4.3.0 (4 October 2026) fixes CVE-2026-93750. That fix covers the Vary wildcard. It does not cover max-stale. GHSA-ch52-4w7c-c8xp still marks every release through 4.2.0. The advisory lists no patched version.
The vulnerable code is reachable at runtime.
cacheable-requestand@cacheable/netboth depend onhttp-cache-semantics4.2.0. Both build aCachePolicywith the default shared cache. The cache key is the method plus the URL. The key does not includeCookieorAuthorization.cacheable-requeststores a security-zeroed entry whenstrictTtlis false. That is the default.satisfiesWithoutRevalidationthen reads the callerCache-Controlheader. A later request for the same URL can send a largemax-stalevalue and receive that stored response. A shared cache can return one user'sSet-Cookieresponse to another user.@cacheable/netenableshttpCachePolicyby default when a cache is present.timeToLive()returns 0 for a security-zeroed response.Cacheabletreats a ttl of 0 as no expiry, so the entry stays. The samemax-stalerequest can read it.A cache that serves one user does not cross users. The libraries do not isolate entries by user. Any shared cache for the same URL can hit this path.
Test audit
This pull request does not add, change, or delete a test. The test gate has no item.
Verification
pnpm installrefreshed the lockfile.pnpm install --frozen-lockfilethen passed.pnpm buildpassed.node scripts/test-build.mjspassed.pnpm test:cipassed for every workspace package.@cacheable/netran againstTEST_URL=http://localhost:3737.cache-managerhad one Redis failure on the first parallel run (mdelnativedeleteMany). The same suite passed on the next run. The failure used a shared Redis while other packages ran.