Probe target compiler for opaque handle size - #379
Open
krystophny wants to merge 3 commits into
Open
Conversation
test_parser.py and test_transform.py reference test/samples/DNAD.fpp, which was never committed because .gitignore excludes *.fpp globally, so both test_parse_dnad cases fail with FileNotFoundError on a clean checkout. Un-ignore .fpp files under test/samples and add the sample from the DNAD project (github.com/joddlehod/dnad, dnad.F90), whose structure matches the assertions in both tests.
numpy 2.5 ships only manylinux_2_28 wheels, so the cp312 and cp313 Linux wheel builds fall back to compiling numpy from source inside the default manylinux2014 container, where gcc 10.2.1 fails numpy's 'requires GCC >= 10.3' check. Build in the manylinux_2_28 image, whose toolchain is new enough and where numpy wheels install directly.
krystophny
force-pushed
the
fix-issue-378-flang-handle-size
branch
from
July 10, 2026 14:17
6f396c0 to
321a206
Compare
|
@krystophny out of interest: this is a targeted fix of the |
Contributor
Author
|
It affects both modes. The handle size is resolved before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fortran-compiler,F90WRAP_FC,F90, orFC--sizeof-fortran-tfor cross-compilers whose probe executable cannot run locallyinteger(c_int)element count in generated Fortran, Direct-C arrays, and generated Python array accessThe handle remains an opaque, byte-preserving container. The change does not interpret descriptor data or alter object ownership and lifetime.
This PR is stacked on #377 so its test fixture and manylinux_2_28 wheel fix are present. Once #377 merges, the remaining functional change is the issue #378 fix.
Fixes #378.
Verification
Test fails on main
Test passes after fix
The gfortran MRE also passes.
Regression suite
Wheel build, isolated installation, compiled-extension import, and both Meson example entries pass.
--build --fortran-compiler flang-newproduces objects identified as LLVM Flang 22.1.6.RABE with Flang
Validated against RABE PR #76 with f90wrap built by gfortran and wrappers built by Flang: