Repository navigation
v2.3.3: fix infinite recursion in _check_stt_quality - #33
Merged
Merged
Conversation
The wrapper called itself instead of assert_segments_acceptable, causing RecursionError on every STT transcription job. Also harden DB migrations: _ensure_column() catches duplicate-column races that surfaced as intermittent test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_stt_qualitycalled itself unconditionally instead of delegating toassert_segments_acceptablefromstt_hallucination.py, causing aRecursionErroron every STT transcription job_ensure_column()helper that also guards theALTER TABLEagainst duplicate-column races (surfaced as intermittent test failures when two fixtures initialised the same DB concurrently)Test plan
RecursionError: maximum recursion depth exceededStorybook preview
Updated for commit 2e38f44.