refactor(api): drop unused is_active from subscription and preauth

api/db/mongodb/migrations/024_subscriptions_unset_is_active.down.json

@@ -0,0 +1 @@
+[]

api/db/mongodb/migrations/024_subscriptions_unset_is_active.up.json

@@ -0,0 +1,13 @@
+[
+  {
+    "update": "subscriptions",
+    "updates": [
+      {
+        "q": { "is_active": { "$exists": true } },
+        "u": { "$unset": { "is_active": "" } },
+        "multi": true
+      }
+    ],
+    "writeConcern": { "w": "majority" }
+  }
+]

api/db/mongodb/subscription_test.go

@@ -119,7 +119,6 @@ func (s *SubscriptionRepositorySuite) seedSub(tier string, activeUntil, updatedA
 		Tier:             tier,
 		ActiveUntil:      activeUntil,
 		UpdatedAt:        updatedAt,
-		IsActive:         true,
 		Notified:         notified,
 		NotifiedInactive: notifiedPD,
 	}
@@ -276,7 +275,6 @@ func (s *SubscriptionRepositorySuite) TestFindDuplicateTokenHashGroups() {
 			Tier:                "IVPN Tier 2",
 			ActiveUntil:         now.Add(30 * 24 * time.Hour),
 			UpdatedAt:           now,
-			IsActive:            true,
 			TokenHash:           tokenHash,
 			DeletionScheduledAt: deletionScheduled,
 		}

api/internal/migrations/subscription_uuid_subtype_test.go

@@ -116,7 +116,6 @@ func (s *MigrateSuite) seedDoc(ctx context.Context, subtype byte, tier string) u
 		{Key: "_id", Value: primitive.Binary{Subtype: subtype, Data: id[:]}},
 		{Key: "account_id", Value: primitive.NewObjectID()},
 		{Key: "active_until", Value: time.Now().Add(30 * 24 * time.Hour).UTC().Truncate(time.Millisecond)},
-		{Key: "is_active", Value: true},
 		{Key: "tier", Value: tier},
 		{Key: "token_hash", Value: "hash-" + tier},
 		{Key: "updated_at", Value: time.Now().UTC().Truncate(time.Millisecond)},
@@ -191,7 +190,6 @@ func (s *MigrateSuite) TestMigrateResumesAfterPartialInsert() {
 	base := bson.D{
 		{Key: "account_id", Value: accountID},
 		{Key: "active_until", Value: time.Now().Add(24 * time.Hour).UTC().Truncate(time.Millisecond)},
-		{Key: "is_active", Value: true},
 		{Key: "tier", Value: "Tier 2"},
 	}
 
@@ -274,7 +272,7 @@ func (s *MigrateSuite) snapshotByUUID(ctx context.Context, coll *mongo.Collectio
 
 func (s *MigrateSuite) assertFieldsPreserved(before, after bson.Raw) {
 	s.T().Helper()
-	preservedKeys := []string{"account_id", "active_until", "is_active", "tier", "token_hash", "updated_at", "notified", "limits"}
+	preservedKeys := []string{"account_id", "active_until", "tier", "token_hash", "updated_at", "notified", "limits"}
 	for _, key := range preservedKeys {
 		beforeVal := before.Lookup(key)
 		afterVal := after.Lookup(key)

api/model/preauth.go

@@ -7,7 +7,6 @@ import "time"
 type Preauth struct {
 	ID          string    `json:"id"`
 	TokenHash   string    `json:"token_hash"`
-	IsActive    bool      `json:"is_active"`
 	ActiveUntil time.Time `json:"active_until"`
 	Tier        string    `json:"tier"`
 }

api/model/subscription.go

@@ -56,7 +56,6 @@ type Subscription struct {
 	ID          uuid.UUID          `json:"-" bson:"_id"`
 	AccountID   primitive.ObjectID `json:"-" bson:"account_id"`
 	ActiveUntil time.Time          `json:"active_until" bson:"active_until"`
-	IsActive    bool               `json:"-" bson:"is_active"`
 	// Type is a legacy pre-0.1.8 enum ("Free"/"Managed") retained so old documents
 	// surface to clients (the beta-ending banner gates on Type == "Managed").
 	// Cleared to "" by the resync flow once the user re-syncs with IVPN.

api/service/account/service_test.go

@@ -145,7 +145,6 @@ func (suite *AccountTestSuite) TestGetUnfinishedSignupOrPostAccount() {
 		preauth := model.Preauth{
 			ID:          preauthID,
 			TokenHash:   tokenHashStr,
-			IsActive:    true,
 			ActiveUntil: activeUntil,
 			Tier:        "pro",
 		}

api/service/subscription/service.go

@@ -109,7 +109,6 @@ func (s *SubscriptionService) CreateSubscriptionFromPreauth(ctx context.Context,
 		ID:          uuid.New(),
 		AccountID:   accOID,
 		ActiveUntil: preauth.ActiveUntil,
-		IsActive:    preauth.IsActive,
 		Tier:        preauth.Tier,
 		TokenHash:   preauth.TokenHash,
 		UpdatedAt:   time.Now(),
@@ -195,7 +194,6 @@ func (s *SubscriptionService) UpdateSubscriptionFromPASession(ctx context.Contex
 	}
 
 	sub.ActiveUntil = preauth.ActiveUntil
-	sub.IsActive = preauth.IsActive
 	sub.Tier = preauth.Tier
 	sub.TokenHash = preauth.TokenHash
 	sub.UpdatedAt = time.Now()

api/service/subscription/service_test.go

@@ -49,7 +49,6 @@ func newPreauthServer(t *testing.T, token string) *httptest.Server {
 		preauth := model.Preauth{
 			ID:          "preauth-id-1",
 			TokenHash:   tokenHashStr,
-			IsActive:    true,
 			ActiveUntil: time.Now().Add(24 * time.Hour).UTC(),
 			Tier:        "IVPN Tier 2",
 		}
@@ -214,7 +213,6 @@ func TestUpdateSubscriptionFromPASession_ClearsLegacyType(t *testing.T) {
 		preauth := model.Preauth{
 			ID:          preauthID,
 			TokenHash:   tokenHashStr,
-			IsActive:    true,
 			ActiveUntil: activeUntil,
 			Tier:        "IVPN Tier 2",
 		}

tests/bootstrap/mock-preauth/server.py

@@ -5,7 +5,7 @@
 
 Endpoints:
   POST /entry  - Create preauth entry (called by test setup)
-    Body: {"id": "...", "token_hash": "...", "is_active": true, "active_until": "...", "tier": "..."}
+    Body: {"id": "...", "token_hash": "...", "active_until": "...", "tier": "..."}
     Returns: 201
 
   GET /<id>    - Get preauth entry (called by API during registration)

tests/libs/accounts.py

@@ -93,7 +93,6 @@ def create_temp_subscription(
         json={
             "id": preauth_id,
             "token_hash": token_hash,
-            "is_active": True,
             "active_until": active_until,
             "tier": tier,
         },