fix(KIM): include harmonic current weight - #275
Draft
marjohma wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
Summary
Derivation check
The perpendicular reduction gives the common FP source term D_0,m proportional to A1 + (1 - m) A2 once the separately represented finite-Larmor-radius pieces are removed. Charge rows already used this coefficient; the two current G1 rows did not.
Red/green evidence
Before the fix, the new j_phi check at m_phi = -1 returned 0.004374 + 0.008559 i instead of 0.003024 + 0.004779 i. The corrected code passes both current rows for all three harmonics.
Verification
All four pass locally after the commit. Independent review reported no findings.