fix(KIM): apply ion FLR scale consistently - #269
Closed
krystophny wants to merge 1 commit into
Closed
Conversation
marjohma
force-pushed
the
agent/kim-257-flr-scale
branch
from
July 28, 2026 10:27
769c03d to
1f95a1f
Compare
Member
|
Closing this draft so it can be recreated under the requested marjohma PR authorship. The replacement will use the same branch and commit. |
Member
|
Replacement: #280, opened by marjohma from the same branch and commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ion_flr_scale_factoraffect only positively charged ion species, never electrons1/Omega_sigma)rho_L_ccexactly once in global integration geometryDerivation convention
The finite-collision derivation gives all four response channels a common
1/Omega_sigmaexternal factor. The artificial ion-FLR knob therefore applies to each ion channel. Separately, background construction already stores an effective scaled ionrho_L, so real-space Bessel geometry must not multiply that stored radius again.Red/green evidence
Before the fix, changing the ion scale from 1 to 4 multiplied the manufactured electron FP prefactors by 4. The geometry seam did not exist, and the global path directly multiplied an already-scaled
rho_L_ccby the knob again. The new test now covers all six affected analytic prefactors and the one-time geometry rule.Verification
test_ion_flr_scale_factortest_integration_methodstest_flr2_fourier_kerneltest_periodic_background_buildtest_periodic_assemblytest_kim_solver_emgit diff --checkAll passed. Independent re-review: no remaining findings.
Closes #257