fix(KIM): restore collisionless j-B parity - #266
Closed
krystophny wants to merge 1 commit into
Closed
Conversation
marjohma
force-pushed
the
agent/kim-254-jb-parity
branch
from
July 28, 2026 10:27
4f134a2 to
0fc7acc
Compare
Member
|
Closing this draft so it can be recreated under the requested marjohma PR authorship. The replacement will use the same branch and commit. |
Member
|
Replacement: #278, opened by marjohma from the same branch and commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z0/kAbsk_parallelparity regression and update the corrected manufactured current referenceVerification
z0/kPoleimplementationctest --test-dir build -R '^(test_collisionless_fourier_kernel|test_collisionless_ion_assembly|test_periodic_assembly|test_periodic_solve|test_kim_solver_periodic)$' --output-on-failureDocumentation follow-up
The external consolidated derivation and Mathematica source still encode the old recurrence and therefore do not regenerate this corrected oracle. That out-of-repository follow-up is recorded explicitly in #263; this PR does not modify external documentation.
Closes #254
Related: #263