Skip to content

feat: add ability to specify word count#4

Open
bguiz wants to merge 1 commit into
itinance:masterfrom
bguiz:feat/count
Open

feat: add ability to specify word count#4
bguiz wants to merge 1 commit into
itinance:masterfrom
bguiz:feat/count

Conversation

@bguiz
Copy link
Copy Markdown

@bguiz bguiz commented Aug 12, 2020

What

  • Current usage:
    • mnemonics
  • New usage:
    • mnemonics 15
    • (plus, current usage retained)
  • Input validation added

Why

  • Add ability for users to specify the number of words they would like in their mnemonic, instead of always using the default value

Note

  • The new functionality was put into src/utils.js, in anticipation of making it easier to write tests.
  • Given that there are currently no tests, I figured that adding them, and adding a test runner, would be something for a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant