EF: add a transport_socket match support to FilterChain match - #3757
Open
wbpcode wants to merge 1 commit into
Open
EF: add a transport_socket match support to FilterChain match#3757wbpcode wants to merge 1 commit into
wbpcode wants to merge 1 commit into
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
istio-testing
added
the
size/M
ramaraochavali
left a comment
ramaraochavali
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one question
| // gateway HTTPS/TLS server that is not in passthrough mode. | ||
| // * `envoy.transport_sockets.quic` - the filter chain terminates | ||
| // QUIC, including the TLS handshake carried within it. | ||
| string transport_socket = 7; |
Contributor
There was a problem hiding this comment.
if user specifies both transport_protocol and this field with contradicting values - the filter wont match? There is no validation at Istio regarding this right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice, the current
transport_protocolcould only be used to detect the filter_chain who accept TLS, but cannot be used to detect the filter_chain who terminates TLS.This limit makes it's very hard if we want to patch TLS context to specific workloads.
A new transport socket match should could cover above scenarios.