Check rest flower - #1
Draft
ishaileshpant wants to merge 2 commits into
Draft
ishaileshpant wants to merge 2 commits into
ishaileshpant wants to merge 2 commits into
Conversation
- add new AggregatorClientInterface to allow switching b/w grpc and rest - endhance existing AggregatorGRPCClient to start using AggregatorClientInterface - added new transport package for rest with AggregatorRESTClient implementing AggregatorClientInterface - added streaming api support with custom content-type - added various connection flag for streaming request - send additional header key "Sender" for better request logging at server side - aligned Rest and gRPC client for most of the init params - added AggregatorRESTServer and necesary changes in aggregator cli and federated/plan get_server method - added transport_protocol settings in defaults/network.yaml, defaulted the same to 'grpc' - reduced cyclomatic complexity of Rest Server - fixed protobuf streaming issue for v1/task/results API - added more detailed logging for task progression and metadata for each api calls - pinned Flask version to latest stable 3.1.0 - addressing review comments - 13th-May - added ping api and `collaborato` constructor hint for `AggregatorClientInterface` - added send_message_to_server in client and AggregatorClientInterface, Rest Server is already at parity - changed base uri for REST server to 'experimental/v1', adjusted the client and tests accordingly rebased 19th.May.1 Signed-off-by: Shailesh Pant <shailesh.pant@intel.com>
ishaileshpant
force-pushed
the
check_rest_flower
branch
3 times, most recently
from
May 19, 2025 17:02
225e27f to
3e54ece
Compare
rebased 19th.May.1 Signed-off-by: Shailesh Pant <shailesh.pant@intel.com>
ishaileshpant
force-pushed
the
check_rest_flower
branch
from
May 19, 2025 17:27
3e54ece to
4b43331
Compare
ishaileshpant
force-pushed
the
native_rest_api
branch
3 times, most recently
from
May 21, 2025 07:51
04abc9e to
c3f3844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Provide a short and descriptive summary of the pull request, e.g., "Improve caching mechanism for API calls"]
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
[Explain the goal of this PR, the problem it solves and a summary of changes made. Reference any related issues or tickets (e.g.,
Fixes #123).]Testing
[Describe the testing done for this PR. If applicable include screenshots.]