evmc: Bump ABI version to 13#1567
Merged
Merged
Conversation
The ABI changed incompatibly since EVMC 12 (evmone 0.21.0) while the version number stayed at 12, so a host built against ABI-12 headers would load the new VM cleanly and then read structs at wrong offsets: - evmc_tx_context layout changed: the TXCREATE initcodes fields were removed (#1514) and block_slot_number was added for EIP-7843 (#1517). - evmc_result lost the reserved optional-data storage (#1529). - EVMC_EOFCREATE was removed from evmc_call_kind, freeing value 5 for future reuse (#1515). - The EVMC_AMSTERDAM revision was added (#1508). This is the first ABI bump since EVMC was merged into evmone, so the version no longer tracks the standalone EVMC project's major version; the doc comment is updated accordingly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1567 +/- ##
=======================================
Coverage 97.36% 97.36%
=======================================
Files 163 163
Lines 14488 14488
Branches 3385 3385
=======================================
Hits 14106 14106
Misses 280 280
Partials 102 102
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR bumps the EVMC ABI version constant to 13 to reflect multiple incompatible EVMC API/ABI changes that occurred while the ABI version remained at 12, preventing hosts built against older headers from accidentally loading a newer VM and misinterpreting struct layouts.
Changes:
- Update
EVMC_ABI_VERSIONfrom12to13. - Update the ABI-version doc comment to clarify the versioning policy and historical linkage to the standalone EVMC project.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABI changed incompatibly since EVMC 12 (evmone 0.21.0) while the version number stayed at 12, so a host built against ABI-12 headers would load the new VM cleanly and then read structs at wrong offsets:
This is the first ABI bump since EVMC was merged into evmone, so the version no longer tracks the standalone EVMC project's major version; the doc comment is updated accordingly.