test: Fix block_reward type to optional<uint64_t>

[chfast]

No description provided.

[Copilot]

Pull request overview

This PR aligns the blockchain test runner’s block reward plumbing with the state::finalize() API by using std::optional<uint64_t> for block rewards, ensuring type consistency when applying mining rewards across forks.

Changes:

• Update apply_block() to accept std::optional<uint64_t> for block_reward.
• Update mining_reward() to return std::optional<uint64_t>.

Comments suppressed due to low confidence (1)

test/blockchaintest/blockchaintest_runner.cpp:236

• mining_reward() now returns std::optional<uint64_t>, but the reward literals are unsuffixed (signed) integer constants. Making them explicitly uint64_t (e.g., ULL) avoids signed→unsigned conversion warnings under -Wsign-conversion and makes the intent clear.

        return 5'000000000'000000000;
    if (rev < EVMC_CONSTANTINOPLE)
        return 3'000000000'000000000;
    if (rev < EVMC_PARIS)
        return 2'000000000'000000000;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.07%. Comparing base (b76a4f8) to head (5616422).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1559   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         162      162           
  Lines       14480    14480           
  Branches     3380     3380           
=======================================
  Hits        14057    14057           
  Misses        305      305           
  Partials      118      118           

Flag	Coverage Δ
eest-develop	91.84% <ø> (ø)
eest-develop-gmp	26.44% <ø> (ø)
eest-legacy	17.69% <ø> (ø)
eest-libsecp256k1	28.08% <ø> (ø)
eest-stable	91.78% <ø> (ø)
evmone-unittests	92.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
core	95.94% <ø> (ø)
tooling	87.81% <ø> (ø)
tests	99.79% <ø> (ø)

Files with missing lines	Coverage Δ
test/blockchaintest/blockchaintest_runner.cpp	85.99% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.