This repository was archived by the owner on Mar 10, 2020. It is now read-only.
[WIP] feat: Support for client-side SSL certs - #601
Open
protometa wants to merge 1 commit into
Open
Conversation
Author
|
Webpack complains about the |
daviddias
suggested changes
Oct 13, 2017
daviddias
left a comment
daviddias
left a comment
Contributor
There was a problem hiding this comment.
Won't this work in the Browser? If so, must be tested only in Node.js
Needs to be documented.
daviddias
suggested changes
Oct 30, 2017
|
|
||
| async.waterfall([ | ||
| (cb) => { | ||
| require('pem').createCertificate({selfSigned: true}, cb) |
Contributor
There was a problem hiding this comment.
Please avoid requiring modules throughout the codebase.
| require('pem').createCertificate({selfSigned: true}, cb) | ||
| }, | ||
| (serverPEM, cb) => { | ||
| require('pem').createCertificate({ |
Contributor
There was a problem hiding this comment.
Specially when you use it multiple times
Contributor
|
@lgierth thoughts here? |
daviddias
changed the title
alanshaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For secure remote proxy access.