[memstore/rid] Don't allow nil value for start/end time#1543
Open
the-glu wants to merge 20 commits into
Open
Conversation
barroco
added
the
dss-raft
the-glu
force-pushed
the
memstore_rid_cleanup_legacy
branch
from
c197978 to
7e1813a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow #1538
It remove some legacy in RID coming from sqlstore. Since ISA/Subscriptions cannot have nill start/end time, this remove this possibility in the memstore layer.
Test have been adapted as well.
Contribute to #1492