Repository navigation
Fix histc(out=) to reject mismatched out dtype instead of silent cast #5380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
N0AHZACH
wants to merge
13
commits into
intel:main
Choose a base branch
from
N0AHZACH:fix-5237-histc-out-dtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7
−2
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ea4c1d7
Reject mismatched out= dtype in histc instead of casting silently
N0AHZACH 272fcab
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH 9bafa70
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH ee3cc7c
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH d355f90
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH d96cdf8
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH d89f76b
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH 6a7c744
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH baee108
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH c569fc4
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH 49b65a7
Address review: drop dead histc xfail scaffolding and duplicate test
N0AHZACH 672fe76
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH dc89b4a
Merge branch 'main' into fix-5237-histc-out-dtype
N0AHZACH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the line:
should be removed in this PR also from
_cuda_xfail_xpu_pass.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BBBela , is this still needed to be done below?