[IMEXRunnerUtils] Update Allclose and printMaxError semantics to handle Nan and inf. - #1225
Merged
Merged
Conversation
…le Nan and inf.
Add a new set of APIs to matches NumPy semantics for `numpy.allclose` and `numpy.isclose`:
- NaNs at the same index are equal *iff* `equal_nan=True`.
- A NaN paired with any non-NaN is never close.
- Infinities are equal *iff* same sign; `+Inf` vs `-Inf` and `Inf` vs finite are not close.
Instead of updating the existing APIs - which
changes their ABI and forces every integration test call site to update —
keep the existing `extern "C"` symbols at their original signatures using
numpy's default equal_nan=True, and expose the equal_nan=False behavior
through new *Strict* symbols:
- `allcloseStrict{F16,BF16,F32}`
- `printAllcloseStrict{F16,BF16,F32}`
- `printMaxErrorStrict{F16,BF16,F32}`
For `printMaxErrorStrict`, additionally surface NaN/Inf mismatches in the printed
report rather than letting them disappear into a silent zero.
Garra1980
approved these changes
Aug 17, 2026
Wrap the _mlir_ciface_allclose signature and the tolerated assignment to satisfy the 80-column limit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new set of APIs to matches NumPy semantics for
numpy.allcloseandnumpy.isclose:Instead of updating the existing APIs - which
changes their ABI and forces every integration test call site to update — keep the existing
extern "C"symbols at their original signatures using numpy's default equal_nan=True, and expose the equal_nan=False behavior through new Strict symbols:allcloseStrict{F16,BF16,F32}printAllcloseStrict{F16,BF16,F32}printMaxErrorStrict{F16,BF16,F32}For
printMaxErrorStrict, additionally surface NaN/Inf mismatches in the printed report rather than letting them disappear into a silent zero.Please review these guidelines to help with the review process: