Repository navigation
Conversation
… and not guaranteed to be externally unique
Contributor
Author
|
@elizabethandrews @tahonermann Sorry this PR took longer to come out than expected, this PR is ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds compilation unit IDs (CUID) to mangled TU-local kernel names, which are only guaranteed to be unique within its own TU, but not necessarily across the program. The CUID comes from already-merged driver changes in #23820.
This is necessary since without distinguishing TUs, TU-local kernels that end up with the same mangled name get silently merged at device link time.
Outstanding tasks:
[[clang::sycl_kernel_entry_point(KernelName)]], i.e. what is used in upstream clang. That needs to be a separate upstream PR.