Skip to content

refactor: Adapt SDK spans to use the kind parameter#857

Merged
GSVarsha merged 2 commits intomainfrom
adapt-sdk-span-kind
Apr 2, 2026
Merged

refactor: Adapt SDK spans to use the kind parameter#857
GSVarsha merged 2 commits intomainfrom
adapt-sdk-span-kind

Conversation

@GSVarsha
Copy link
Copy Markdown
Contributor

@GSVarsha GSVarsha commented Apr 1, 2026

For the following code snippet,

import instana
from instana.singletons import tracer

import requests
from opentelemetry.trace import SpanKind

with tracer.start_as_current_span("test-span", kind=SpanKind.SERVER) as span:
    response = requests.get("https://www.httpbin.org/get")
    print(response.json())

Before the fix

For custom ENTRY span:

  • Sub calls: 3
  • The kind parameter of start_span has no effect
Screenshot 2026-04-01 at 12 37 18 PM

After the fix

For custom ENTRY span:

  • Sub calls: 2
  • The kind parameter of start_span reflected in span.kind as expected
Screenshot 2026-04-01 at 12 36 52 PM

@GSVarsha GSVarsha added this to the H1-2026 milestone Apr 1, 2026
@GSVarsha GSVarsha self-assigned this Apr 1, 2026
@GSVarsha GSVarsha added fix OTel OpenTelemetry compatibility. labels Apr 1, 2026
GSVarsha added 2 commits April 1, 2026 17:59
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

@GSVarsha GSVarsha marked this pull request as ready for review April 1, 2026 12:55
@GSVarsha GSVarsha requested a review from a team as a code owner April 1, 2026 12:55
Copy link
Copy Markdown
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@GSVarsha GSVarsha merged commit 30af68f into main Apr 2, 2026
19 checks passed
@GSVarsha GSVarsha deleted the adapt-sdk-span-kind branch April 2, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix OTel OpenTelemetry compatibility. refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Kind Parameter of start_span has no affect

2 participants