Skip to content

load_data: narrow bare except and report the prep_* failure cause #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunjunz merged 1 commit into from
Aug 24, 2026
Merged

load_data: narrow bare except and report the prep_* failure cause #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/mintpy/load_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,9 @@ def prepare_metadata(iDict):
ut.print_command_line(script_name, iargs)
try:
prep_module.main(iargs)
except:
warnings.warn('prep_nisar.py failed. Assuming its result exists and continue...')
except Exception as e:
warnings.warn(f'{script_name} failed ({type(e).__name__}: {e}). '
'Assuming its result exists and continue...')

elif processor == 'isce':
from mintpy.utils import isce_utils, s1_utils
Expand Down Expand Up @@ -721,8 +722,9 @@ def prepare_metadata(iDict):
ut.print_command_line(script_name, iargs)
try:
prep_module.main(iargs)
except:
warnings.warn('prep_isce.py failed. Assuming its result exists and continue...')
except Exception as e:
warnings.warn(f'{script_name} failed ({type(e).__name__}: {e}). '
'Assuming its result exists and continue...')

# [optional] for topsStack: SAFE_files.txt --> S1A/B_date.txt
if os.path.isfile(meta_file) and isce_utils.get_processor(meta_file) == 'topsStack':
Expand Down Expand Up @@ -789,8 +791,9 @@ def prepare_metadata(iDict):
ut.print_command_line(script_name, iargs)
try:
prep_module.main(iargs)
except:
warnings.warn('prep_gmtsar.py failed. Assuming its result exists and continue...')
except Exception as e:
warnings.warn(f'{script_name} failed ({type(e).__name__}: {e}). '
'Assuming its result exists and continue...')

return

Expand Down