Skip to content

[ADD] google_tag_manager_advanced_tracking: GA4 API Secret placeholder field - #483

Open
fw-bot-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-18.0-t-66923-jr-8428-fw
Open

[ADD] google_tag_manager_advanced_tracking: GA4 API Secret placeholder field#483
fw-bot-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-18.0-t-66923-jr-8428-fw

Conversation

@fw-bot-adhoc

Copy link
Copy Markdown

Qué

Agrega un campo ga4_api_secret (Char) en website, su related en
res.config.settings y el setting correspondiente bajo Website → Tracking &
SEO
, justo debajo del setting nativo de Google Analytics.

Espeja el campo homónimo que en 19.0 define website_sale_google_analytics_4.

Por qué

En v18 el campo es un placeholder: solo almacena el valor. Permite que los
clientes que hoy están en 18.0 generen y carguen su GA4 Measurement Protocol
API Secret (server-side)
antes de actualizar a 19.0, donde
website_sale_google_analytics_4 lo consume para los eventos server-side
(purchase, refund).

Durante el pase v18→v19, el Upgrade Line de deprecación del stack GTM migra el
valor al campo homónimo del módulo nuevo. Mantener el mismo nombre técnico
(website.ga4_api_secret) es lo que hace que la columna sea reutilizable y el
dato no se pierda.

Test plan

  • Instalar/actualizar google_tag_manager_advanced_tracking en una base 18.0.
  • Ir a Ajustes → Sitio web → Tracking & SEO: con Google Analytics activo,
    aparece GA4 API Secret (Server-side) con su input.
  • Cargar un valor y guardar; verificar que persiste en website.ga4_api_secret.

Task: https://www.adhoc.inc/odoo/project.task/66923

Forward-Port-Of: #481

…r field

Add a dummy `ga4_api_secret` Char on website (+ res.config.settings related
field and its setting under Website > Tracking & SEO), mirroring the v19 field
defined by website_sale_google_analytics_4.

In v18 the field only stores the value: it lets clients generate and load their
GA4 Measurement Protocol API Secret (server-side) before the v18->v19 upgrade.
The GTM-deprecation Upgrade Line migrates the value to the homonymous field of
website_sale_google_analytics_4 during the upgrade.

Task #66923.

X-original-commit: ee833fc
@roboadhoc

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@fw-bot-adhoc

Copy link
Copy Markdown
Author

@JrAdhoc @augusto-weiss cherrypicking of pull request #481 failed.

stdout:

Auto-merging google_tag_manager_advanced_tracking/__manifest__.py
CONFLICT (content): Merge conflict in google_tag_manager_advanced_tracking/__manifest__.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

:shipit: you can use git-fw to re-do the forward-port for you locally.

⚠️ after resolving this conflict, you will need to merge it via @roboadhoc.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants