fix: remove unnecessary IsAvailable gate from index_stats - #86
Closed
SteveLauC wants to merge 1 commit into
Closed
Conversation
SteveLauC
changed the title
CatShards and CatIndices are read-only cat APIs that work regardless of cluster health status. There is no reason to gate them behind IsAvailable, which caused shard_info and index_info to be null in the inspect flow where the flag is never set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CatShards and CatIndices are read-only cat APIs that work regardless of
cluster health status. There is no reason to gate them behind
IsAvailable, which caused shard_info and index_info to be null in the
inspect flow where the flag is never set.
Standards checklist