ci: add downstream github action assurance gate#132
Merged
Conversation
Build the current-branch CLI and drive the official imposter-github-action against it, so breaking changes to CLI commands or arguments are caught before reaching downstream consumers.
outofcoffee
force-pushed
the
ci/test-downstream-github-action
branch
from
4bb5cee to
225ae9e
Compare
Drop the now-deprecated engine-type input from the stop-mocks step, and point setup-go's build cache at the CLI checkout under cli/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise the official imposter-github-action against the CLI built from the current branch, so breaking changes to CLI commands or arguments are caught before they reach downstream consumers.
Summary
.github/workflows/downstream-action.yaml, running onpushandpull_request.make buildand place it onPATHat/usr/local/bin/imposter, where the action expects to find it.start-mocks(imposter engine pull+imposter up) andstop-mocks(imposter down), then assert the mock responds and that it stops.Implementation details
setupstep is deliberately skipped. It installs the released CLI from GitHub, which would mask the change under test; instead the branch binary is placed at the same locationsetupwould use.mainso the gate reflects the latest downstream code.4.5.4so a failure indicates a CLI change rather than a new engine release.mainstill callsimposter down -t <engine>, but the CLI'sdowncommand no longer accepts-t. The gate will pass once that fix lands in the action'smain.