Resolve forge linter issues, remove solhint, remove unused files#297

Merged

drinkcoffee merged 11 commits into

mainfrom

peter/resolve-linter-warnings

May 25, 2026

Contributor

drinkcoffee commented May 22, 2026 •

edited

Loading

This PR:

Removes Immutable X related files. This was done to reduce the number of warnings to resolve.
Resolves all forge linter issues
Removes solhint
Formats code using "forge fmt"
Updates copyright notices to 2026.
Excludes from forge linter and formatter OwnableCreate3 files that can't change.

drinkcoffee added 3 commits

May 22, 2026 14:28


          First pass of resolving compiler warnings

6261d5e


          More linter changes

6ff6739


          Remove solhint

8c9ec36

drinkcoffee changed the title ~~[DRAFT] Resolve forge linter issues, remove solhint, remove unused files~~ Resolve forge linter issues, remove solhint, remove unused files

drinkcoffee marked this pull request as ready for review

May 22, 2026 07:43

drinkcoffee requested review from a team as code owners

May 22, 2026 07:43

drinkcoffee requested review from ermyas, lfportal and rytimx

May 22, 2026 07:43


          Merge branch 'main' into peter/resolve-linter-warnings

658b9c8

lfportal reviewed

View reviewed changes

contracts/trading/seaport/validators/ReadOnlyOrderValidator.sol

lfportal reviewed

View reviewed changes

contracts/trading/seaport/validators/SeaportValidator.sol

lfportal reviewed

View reviewed changes

contracts/trading/seaport/validators/SeaportValidatorHelper.sol

ermyas previously approved these changes

View reviewed changes

lfportal reviewed

View reviewed changes

contracts/trading/seaport16/validators/ReadOnlyOrderValidator.sol

lfportal reviewed

View reviewed changes

contracts/trading/seaport16/validators/SeaportValidator.sol

lfportal reviewed

View reviewed changes

contracts/trading/seaport16/validators/SeaportValidatorHelper.sol

drinkcoffee added 2 commits

May 25, 2026 10:31


          Re-add validators used in active deployment

4d9b718


          Merge branch 'peter/resolve-linter-warnings' of https://github.com/im…

f25fdb3

…mutable/contracts into peter/resolve-linter-warnings

drinkcoffee dismissed ermyas’s stale review via

f25fdb3

May 25, 2026 00:33

drinkcoffee added 5 commits

May 25, 2026 13:02


          Terminate forge-lint starts

11a4115


          Add end for slither exclusion

077ce23


          Revert changes to OwnableCreate3 related files and add to linter excl…

bfc4f51

…usions


          Revert formatting and exclude from future formatting


          Fix formatting

6d78797

lfportal approved these changes

View reviewed changes

drinkcoffee merged commit 5ba9992 into main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet