Repository navigation
test(ui-tweaks): check the signed annotation-submit contract semantically - #1622
Merged
Merged
Conversation
…ally The signed-bundle test located the native shortcut owner by the app-initial-* chunk name and required ten minified functions from the frozen fixture to appear byte-for-byte in the official ASAR. Since 26.1021.22027 the owner lives in app-runtime-* and every minified name changed, so the test failed even though the patch applies correctly. CI never runs this file with CODEX_SIGNED_EXTRACTED_APP, so the failure went unnoticed; the upstream watchdog now runs every signed-bundle test. Discover the owner the same way the patch does, require exactly one, apply the patch to a copy of the official app, and keep the combined more-details check. The frozen fixture still drives the behavioral tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux-features/ui-tweaks/selected-text-annotation-submit.test.jshas one test that runs only withCODEX_SIGNED_EXTRACTED_APP. Against the current signed release 26.1021.22027 it failed, although the patch itself applies correctly (matched 1, changed 1, targetapp-runtime-*.js):app-initial-*chunks, but upstream moved it toapp-runtime-*;CI's signed-baseline job never runs this file with the signed bundle, so nothing caught it. The upstream watchdog now runs every test that reads
CODEX_SIGNED_EXTRACTED_APPduring acceptance, so this stale test would block the next release campaign.The test now discovers the owner the same way the patch does, requires exactly one, checks that the patched source validates, applies the patch to a copy of the official app, and keeps the combined more-details check. The frozen fixture still drives the behavioral tests.
Validation
CODEX_SIGNED_EXTRACTED_APPtests against the signed 26.1021.22027 amd64 bundle: 145 pass, 0 fail, 2 skippedui-tweakssuite without the bundle: 243 pass; the signed test skipsgit diff --check🤖 Generated with Claude Code